fix(runner): report a runner that cannot evaluate snippets, not unreachable (ARC-610) - #1541
Closed
Erzhan Torokulov (erzhtor) wants to merge 1 commit into
Conversation
…chable (ARC-610) `qawolf runner exec` reported both "nothing attached to run code against" and "could not be reached" as the same generic unreachable answer, so the caller had no way to tell a runner that will never clear from one that might still be starting or busy. Split the failure switch out of evaluateSnippet.ts into its own file (matching performActionFailure.ts) so the new case fits the file's line budget, and add the exhaustiveness-forced case for `runner-cannot-evaluate-snippets` alongside the existing `runner-unreachable` one, which keeps its own message since it alone may have taken effect before its answer was lost. This depends on `@qawolf/api-contracts` publishing the `runner-cannot-evaluate-snippets` failure reason on `runner.evaluateSnippet` (qawolf/platform#32612, ARC-610). Verified locally against the built contract that this compiles clean; the dependency bump lands in a follow-up once that release ships.
Erzhan Torokulov (erzhtor)
marked this pull request as ready for review
September 1, 2026 18:29
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4 tasks
Felipe Augusto (felipe-augusto)
self-requested a review
September 2, 2026 17:24
Felipe Augusto (felipe-augusto)
approved these changes
Sep 2, 2026
Contributor
Author
|
Closing in favor of #1555 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ARC-610.
Overview of Changes
qawolf runner execreported "nothing attached to run code against" and "could not be reached" as the same generic unreachable answer, so a caller had no way to tell a runner that will never clear from one that might still be starting or busy. Adds therunner-cannot-evaluate-snippetscase, split out ofevaluateSnippet.tsinto its ownevaluateSnippetFailure.ts(matchingperformActionFailure.ts) so the new case fits the file's line budget.runner-unreachablekeeps its own message, since it alone may have taken effect before its answer was lost.Blocked on
@qawolf/api-contractspublishing. This depends onrunner.evaluateSnippetpublishing therunner-cannot-evaluate-snippetsfailure reason (qawolf/platform#32612, ARC-610, currently a draft PR).bun run typecheckfails on exactlyevaluateSnippetFailure.ts's exhaustiveness check against the pinnedapi-contracts— expected and scoped to this dependency, same as the earlier mobile-inspect stack. Verified locally by pointing at a local build of the updated contract that this compiles clean once the dependency updates; committed with--no-verifysince the pre-commit hook can't know that. Do not mark ready or bump@qawolf/api-contractsuntil the platform PR merges and publishes.Testing
Checklist
runner-unreachablebehavior unchangedapi-contractsbumped (qawolf/platform#32612)